Skip to content

Expose all extrinsic and storage to EVM #1639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
May 30, 2025
Merged

Conversation

open-junius
Copy link
Contributor

@open-junius open-junius commented May 15, 2025

Description

Related Issue(s)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Other (please describe):

Breaking Change

If this PR introduces a breaking change, please provide a detailed description of the impact and the migration path for existing applications.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have run cargo fmt and cargo clippy to ensure my code is formatted and linted correctly
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots (if applicable)

Please include any relevant screenshots or GIFs that demonstrate the changes made.

Additional Notes

Please provide any additional information or context that may be helpful for reviewers.

@distributedstatemachine
Copy link
Collaborator

I believe this will address this ? #1632

@open-junius open-junius marked this pull request as ready for review May 17, 2025 14:42
@open-junius open-junius self-assigned this May 17, 2025
@open-junius open-junius added the skip-cargo-audit This PR fails cargo audit but needs to be merged anyway label May 17, 2025
@open-junius open-junius changed the title init solution Expose all extrinsic and storage to EVM May 17, 2025
@open-junius open-junius requested review from a team, l0r1s and ales-otf May 29, 2025 12:56
let maxChildkeyTake = 257;
await setMaxChildkeyTake(api, maxChildkeyTake)

api.query.SubtensorModule.MaxChildkeyTake.getValue();
Copy link
Collaborator

@l0r1s l0r1s May 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line needed given value is not stored in a variable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just check the value can be got after setMaxChildkeyTake, without exception. maybe it is not necessary, will consider to remove it in the future.

@open-junius open-junius merged commit bef974e into devnet-ready May 30, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-cargo-audit This PR fails cargo audit but needs to be merged anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants